refactor(web-config): remove mention to stable config as config.json source #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…source Signed-off-by: GitHub <[email protected]>
ferferga
force-pushed
the
web-config
branch
from
6de7981
to
f673098
Compare
Cloudflare Pages deployment
|
|
Changes to (web) plugins will likely be problematic (cause failed imports). |
|
@thornbill Any chance the wrong imports can gracefully fail so it doesn't matter or that's a difficult thing to tackle right now? |
|
I did some testing and failing to load a plugin should not cause issues, but any change to the path of existing plugins would still cause breakages of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is out of date already and with the faster cadence of releases we plan to have, this can easily become a burden to maintain.
@thornbill Does web break if the json file contains keys that it's not aware of (that's the only incompatibility I can see, some new setting introduced in an update)? Or it's able to just pick the ones that it expects correctly?
Marking as a draft until we have OK from Bill in that regard