Added matching rule to audit trail table #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walisc
requested changes
Feb 20, 2024
| @@ -30,7 +30,7 @@ import { PatientRecord, GoldenRecord, AnyRecord } from 'types/PatientRecord' | |||
| import { sortColumns } from 'utils/helpers' | |||
| import getCellComponent from 'components/shared/getCellComponent' | |||
| import { AUDIT_TRAIL_COLUMNS } from 'utils/constants' | |||
| import { AuditTrail } from 'types/AuditTrail' | |||
| import { AuditTrail, ExpandedAuditTrail } from 'types/AuditTrail' | |||
There was a problem hiding this comment.
I dont think you should create a new type. The change is too small (i.e not worth the extra complexities) . Just update the current version of the AuditTrail type with the additional type.
| @@ -419,6 +455,35 @@ export class ApiClient { | |||
| } | |||
| } | |||
|
|
|||
| const extractMatchingRule = (input: string ) => { | |||
There was a problem hiding this comment.
This is not the correct way of doing this. As much as possible avoid using heuristic for your logic...i.e assuming the string will always be of a particular format , or if the score is x then it is DETERMINISTIC (this is actually not the case always)
What you want to do is send back this data with the correct info already, removing the need to use heuristic. i.e getGoldenRecordAuditTrail should return a json object like
[
{
"text": "Matched with score....etc",
"matchType": "DETERMINISTIC"
}
]and then extract the information from there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Description of changes
Modified response from response from back end for the audit trails (ExpandedAuditTrail)
Expanded the response by adding a field called matching rule
Extracted the score using a regex expression on the (EventAuditTrailEntry)
Added a column on the audit trail (Matching Rule)
Displayed matching rule on the audit trail table
2. Testing
Navigate to