-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Algolia's dark theme when needed #7871
Conversation
Thanks for tagging me! I really appreciate you building on the fix from my PR (#7869). Your idea of using Algolia's own dark theme for better contrast looks fantastic. I also got to learn a lot from your changes, which will definitely help me moving forward. Thanks again for your effort and for sharing these insights! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion -
Do you think we can have a greyish border around the searchbox
in dark theme ?
How about it ? Since I think it will make the searchbox
a bit more distinctly looked on in the dark theme ;which is not present now unless we hover over it .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now . Thanks very much !
Co-authored-by: Kris Stern <[email protected]>
Thanks @zbynek! |
Before #7869 there were 3 elements with poor contrast in dark mode and the popup looked fine in light mode. That PR fixed contrast for one of the elements in dark mode, which is an improvement, but comes at the cost of lower contrastin light mode. The two symbols marked in red remain barely isible:
![image](https://private-user-images.githubusercontent.com/1105305/412630926-a35225b0-493e-4b44-8e72-dd93c958633a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NTM4MTMsIm5iZiI6MTczOTY1MzUxMywicGF0aCI6Ii8xMTA1MzA1LzQxMjYzMDkyNi1hMzUyMjViMC00OTNlLTRiNDQtOGU3Mi1kZDkzYzk1ODYzM2EucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMjEwNTEzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTVhNTlkYWY0ZmViYzllOWExMjZkZWRlYTQ0NjFlNzEyM2NmYWFlMmNiZjExODkzNTI0YjUyYWU4MzNmMzM4NSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.YRaiatkMRI0HtwisqjeM3qJ0mUOZ-fMf0Y2t1aigpwM)
I think the preferable approach here is to use Algolia's own dark styles in dark mode and keep light mode as is.
CC @biru-codeastromer