Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contributing.yaml for update cli #907

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

saurabhraghuvanshii
Copy link

close #906

Add updateCli to keep contributing.md up to date .

@saurabhraghuvanshii saurabhraghuvanshii requested a review from a team as a code owner February 12, 2025 19:18
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good job, thanks!

I've added a few suggestion, some are nit picking, other are blocking. Mainly, I would suggest to keep the same documentation block with prerequisites updated.

The addition of many details makes the change hard to maintain for us:

  • URL are fragile and could break quite often
  • The amount of PRs opened by the manifest in its current state will be quite high for a low value (JDK and maven version are HIGH value, but knowing the current version of the agent, which changes 1 or 2 a week is low value)

I guess it underlines that the Jenkins infrastructure is missing a real "documentation" webstie with permalink and details

@saurabhraghuvanshii
Copy link
Author

done sir

@saurabhraghuvanshii
Copy link
Author

done sir

@smerle33
Copy link
Contributor

in order to have a fully functionnal updatecli, we need :

@saurabhraghuvanshii
Copy link
Author

@smerle33 sir check it, is changes are correct or not .

@smerle33
Copy link
Contributor

@smerle33 sir check it, is changes are correct or not .

@saurabhraghuvanshii it's incorrect, and I will try to find some time to explain and detail next week, thanks for your time and help

@saurabhraghuvanshii
Copy link
Author

sorry sir, I will try to do . thanks for support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use updatecli to keep contributing.md up to date
3 participants