Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74028] Extract inline script from choiceParameterCommon.jelly #372

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

yaroslavafenkin
Copy link

https://issues.jenkins.io/browse/JENKINS-74028

Testing done

Created a freestyle project with 2 Active Choices Parameters. Took sample Groovy scripts from the README. Choice type - Multi Select.

Before the change
After the change

P.S. On the After the change video you'll see CSP violations in the report. Those aren't related to this change, and are fixed in #371. The reason they didn't appear on the Before video is because it was recorded with the plugin version built from #371.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@yaroslavafenkin yaroslavafenkin requested a review from a team as a code owner November 1, 2024 19:17
@kinow kinow merged commit fd36e1a into jenkinsci:master Nov 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants