#428-add-support-to-pr:reviewer:approved-event

[MayaPetter]

adding support to reviewer approval event to update the build

Your checklist for this pull request

• [x ] Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
• [ x] Ensure that the pull request title represents the desired changelog entry
• [ x] added SERVER_PULL_REQUEST_APPROVED event to NativeServerPullRequestHookProcessor.java and WebhookConfiguration.java
• [x ] add-support-to-pr:reviewer:approved-event #428
• Link to relevant pull requests, esp. upstream and downstream changes
• [ x] Did you provide a test-case? That demonstrates feature works or fixes the issue.-
  tested locally on a multibranch job, triggered scanning on or approval on bitbucket server

[MayaPetter]

@tandibar @lucaspanjer @cris

[wahammed]

Who can merge this?

[bitwiseman]

@wahammed
There was a question on #428 as to whether this applies to Cloud. I think it does.
https://support.atlassian.com/bitbucket-cloud/docs/event-payloads/#Approved

[bitwiseman]

Why was this deleted? I assume this was deleted to make a test pass?

[MayaPetter]

Hi, it was probably a mistake, I didn't try to delete it...

[bitwiseman]

This event is also present in Bitbucket Cloud.
https://support.atlassian.com/bitbucket-cloud/docs/event-payloads/#Approved

And it was added to this codebase:
https://github.com/jenkinsci/bitbucket-branch-source-plugin/blob/master/src/main/java/com/cloudbees/jenkins/plugins/bitbucket/hooks/HookEventType.java#L62

But then it is never used. 😭

Please update this PR to add the Cloud version as well.

[jverhoeven]

@MayaPetter would you be so kind to complete this PR? We are running into the same issue and prefer to have this fixed in main plugin and not our own compiled one. Many thanks!

[jkurek1]

Hi,
Any progress on that feature? It would be really good to have it.