Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP token authentication for bitbucket server #924

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

nfalco79
Copy link
Member

Fix null credentialsId passed to GitSCM when authentication is username/password or the StandardUsernameCredential provided by the BitbucketAuthenticator is null.

@nfalco79
Copy link
Member Author

This would fix issue #904

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@nfalco79 nfalco79 force-pushed the feature/auth_username_password_failure branch from bee980f to c38994e Compare November 26, 2024 18:22
@nfalco79 nfalco79 marked this pull request as ready for review November 26, 2024 18:22
@nfalco79 nfalco79 force-pushed the feature/auth_username_password_failure branch from c38994e to 7307e24 Compare November 26, 2024 18:24
…me/password or the StandardUsernameCredential provided by the BitbucketAuthenticator is null.
@nfalco79 nfalco79 force-pushed the feature/auth_username_password_failure branch from 7307e24 to 6322dbc Compare November 26, 2024 18:32
@nfalco79 nfalco79 merged commit 6a215c8 into master Nov 26, 2024
19 checks passed
@nfalco79 nfalco79 deleted the feature/auth_username_password_failure branch November 26, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant