Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading in logging statement in parallelPipeline Method #2566

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

logresearch
Copy link
Contributor

Description

This PR updates the logging statement in the parallelPipeline method to accurately reflect the action being performed. The previous log message indicated that a parallel pipeline was being “edited,” while the surrounding code clearly shows that a new parallel pipeline is being created from scratch.

Reason for the Change

The original log statement was misleading, suggesting that an existing pipeline was being modified rather than a new one being created. This could cause confusion for developers and maintainers when reviewing logs. The new log statement more accurately describes the process of creating a new parallel pipeline, thus improving the clarity and accuracy of the code’s documentation through logs.

Testing

Verified that the method performs as expected and that the new logging message appears correctly in the logs during execution.

@logresearch logresearch requested a review from a team as a code owner July 24, 2024 09:13
The original logging statement incorrectly logged the range of branch numbers as [1-(number + 1)], which implies that one more branch than specified is created. The update corrects this by logging the range as [1-number], matching the actual number of branches created in the loop.
@logresearch
Copy link
Contributor Author

Another update in GitRepositoryRule.java

The original logging statement incorrectly logged the range of branch numbers as [1-(number + 1)], which implies that one more branch than specified is created. The update corrects this by logging the range as [1-number], matching the actual number of branches created in the loop.

@olamy olamy merged commit 3d7b358 into jenkinsci:master Jul 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants