Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: implement retry in app upload and improve logging #83

Merged
merged 2 commits into from
Oct 21, 2024
Merged

update: implement retry in app upload and improve logging #83

merged 2 commits into from
Oct 21, 2024

Conversation

abhinvv1
Copy link
Contributor

@abhinvv1 abhinvv1 commented Oct 14, 2024 •
edited
Loading

What is this PR for?

As part of this PR:

  1. Implemented a retry on app-upload in case of failure due to AppAutomateException
  2. Added more logging for error scenarios

JIRA: https://browserstack.atlassian.net/browse/AAP-14148

Screenshot 2024-10-15 at 12 44 48 PM incase of AppAutomateException the console output with retrying and improved logging

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@rushi04
Copy link

rushi04 commented Oct 15, 2024

Do we have UT's for these files ?

@abhinvv1
Copy link
Contributor Author

Do we have UT's for these files ?

no we dont have Uts for them

francisf
francisf approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@francisf francisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for merge

@francisf francisf merged commit 03a5e00 into jenkinsci:master Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rits1272 Rits1272 Rits1272 approved these changes

@rushi04 rushi04 rushi04 approved these changes

@francisf francisf francisf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhinvv1 @rushi04 @francisf @Rits1272