Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Parallelize Tests #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rahulsom
Copy link

This will use all available cores to run tests, and parallelize by all - suite/class/method. On machines with multiple cores, this will vastly improve test performance. These times are on my M1 MBP with 10 (8P + 2E) cores. They were reported by maven on running mvn verify.

I first ran mvn verify and ignored the time.
Then I ran it thrice without this change, and thrice with this change.

All times in seconds.

Run 1 Run 2 Run 3 Average
Before 519 516 519 518
After 123 124 124 124
Savings 394
% 76

Testing done

All existing tests pass

Submitter checklist

Preview Give feedback

This will use all available cores to run tests, and parallelize by all - suite/class/method.
On machines with multiple cores, this will vastly improve test performance.
These times are on my M1 MBP with 10 (8P + 2E) cores. They were reported by maven on running `mvn verify`.

I first ran `mvn verify` and ignored the time.
Then I ran it thrice without this change, and thrice with this change.

All times in seconds.

|        | Run 1 | Run 2 | Run 3 | Average |
| ------ | ----: | ----: | ----: | ------: |
| Before |   519 |   516 |   519 |     518 |
| After  |   123 |   124 |   124 |     124 |
| Savings|       |       |       |     394 |
| %      |       |       |       |      76 |
@rsandell
Copy link
Member

The test failure is somewhat legit. Running too many tests in parallel on lower end hardware/vm will cause timing issues and make com.sonyericsson.jenkins.plugins.bfa.model.FailureReaderTest.testScanOneFileWithLineTimeout flaky.

@rsandell rsandell added the chore label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants