-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Java 17 and 2.475; adapt test suite to EE 9 #182
Conversation
4b30813
to
2ac5231
Compare
Should fix JENKINS-73903, I think. |
@basil |
@TWestling Yes exactly. When 2.479.1 LTS is released on October 30, I will file another PR in this repository to move back to the LTS line. |
Thanks @TWestling! Could this please be released? That way, users will be able to upgrade to 2.479.1 LTS next week with a fully working set of plugins. |
@basil My plan was to release it now, thought I'd try it out first, and when running hpi:run, I get: Any idea why? Running on Maven 3.9.8 and JDK 17. |
Managed to test this in a roundabout way, so the plugin is now released. |
I will file a PR next Wednesday when 2.479.1 is released that will clean up the parent POM, switch back to LTS, and restore |
No worries, just glad that it seems you know what the issue is :) |
Done in #183 |
Subsumes #181. Allow this plugin's test suite to be exercised regularly in Plugin Compatibility Tester (PCT) in https://github.com/jenkinsci/bom by requiring Java 17 or newer and Jenkins 2.475 (released today) or newer.
This PR goes against the usual advice from https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ by requiring a weekly release. The advantage is that this will allow plugin compatibility testing (PCT). The disadvantage is that new features and bug fixes can't be released to LTS users for another few months.
The choice is up to the maintainer as to whether or not to accept this PR. If this PR is rejected, we will stop testing this plugin in PCT.