-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: factorize JDK specification to docker bakefile (linux) / compose file (windows) #409
chore: factorize JDK specification to docker bakefile (linux) / compose file (windows) #409
Conversation
ac5073d
to
b301cdf
Compare
49c995e
to
daf41df
Compare
any way to see if anyone actually uses Archlinux? |
def8060
to
7f92859
Compare
The DockerHub download stats would be useful there |
7f92859
to
f62a799
Compare
Rebased on top of #414 : let's see if it works as expected |
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
33230e9
to
2dfd7b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me.
chore(updatecli) fix JDK version tracking - fixup of #409
…#409 Signed-off-by: Damien Duportal <[email protected]>
chore: fix Dockerfile location on the last items - fixup of #409
Please note that the following fixup changes were needed after this PR: |
Blocked by #414
This pull request aims at factorizing the image definitions (
Dockerfile
s) to avoid duplicating code between JDK versions.Until now, changing an element in any of the images which have both JDK11 and JDK17 definitions were subject to a risk of shift if the 2nd image is forgotten.
How does it work?
11/
and17/
, representing the major JDK version, are removedbullseye
is renamed todebian
during this change for the following reasons:Dockerfile
as part of theFROM
instruction and is subject to change in the futuresDockerfile
s do have a default version defined to ensure it's buildable "as it" (e.g. without Docker BuildX and its bake file). The proposed convention is to set it to the "most recent LTS JDK of the images"..TODO:
Testing done
Submitter checklist