Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Java 21 #285

Merged
merged 5 commits into from
Nov 11, 2023
Merged

Conversation

MarkEWaite
Copy link
Contributor

Test with Java 21

Java 21 released Sep 19, 2023. We'd like to announce full support for Java 21 in early October and would like the most used plugins to be compiling and testing with Java 21.

The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.

Java 11 will be unsupported by Eclipse Temurin and some other Java providers in October 2024. We'll need to move past Java 11 by that time. It does not change the supported Java version or the byte code that is being generated. This intentionally does not include Java 11 in the test configuration because Java 11 byte code is being generated by the Java 17 and Java 21 compilation and because Java 11 is being tested at least weekly by the plugin bill of materials.

Supersedes the following pull request:

Also removes hamcrest dependency declaration since it is provided by the parent pom.

Also removes a compiler warning by annotating a deprecated method.

Testing done

Confirmed tests pass with Java 21 on Linux

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

dependabot bot and others added 5 commits September 1, 2023 09:27
Bumps [org.jenkins-ci.plugins:plugin](https://github.com/jenkinsci/plugin-pom) from 4.71 to 4.73.
- [Release notes](https://github.com/jenkinsci/plugin-pom/releases)
- [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/plugin-pom@plugin-4.71...plugin-4.73)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Deprecation of the method happened at the same time as the other
deeprecations in the file, but the Deprecated annotation was missed on
this method but included on the other methods.
Java 21 released Sep 19, 2023. We'd like to announce full support for
Java 21 in early October and would like the most used plugins to be
compiling and testing with Java 21.

The acceptance test harness and plugin bill of materials tests are already
passing with Java 21. This is a further step to improve plugin readiness
for use with Java 21 and for development with Java 21.

Java 11 will be unsupported by Eclipse Temurin and some other Java
providers in October 2024. We'll need to move past Java 11 by that
time. It does not change the supported Java version or the byte code
that is being generated.

This intentionally does not include Java 11 in the test configuration
because Java 11 byte code is being generated by Java 17 and Java 21
compilation and tested in those configurations.

Also improves test performance on ci.jenkins.io by running in parallel.
@MarkEWaite MarkEWaite requested a review from a team as a code owner October 8, 2023 12:21
@MarkEWaite
Copy link
Contributor Author

@NotMyFault I'd appreciate if you would merge this pull request so that the primary branch is being tested with Java 21. No need for a release, just a merge.

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely, I must have missed the PR!

@NotMyFault NotMyFault merged commit 900abc3 into jenkinsci:master Nov 11, 2023
17 checks passed
@MarkEWaite MarkEWaite deleted the test-with-java-21 branch November 11, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants