Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error Message for Environment Variable Injection Conflicts #288

Closed

Conversation

matthewchivers
Copy link

@matthewchivers matthewchivers commented Jun 18, 2024

This PR improves the error message logged when not all environment variables can be successfully injected. I believe the updated message provides clearer information about potential conflicts with existing environment variables that may have the same name.

The cause of this error was not immediately obvious to me when reviewing failures in Jenkins output - so this is just a slight improvement to the error message (subjective).

Changes:

  • Updated the error message in EnvInjectEnvVarsContributor.java to clarify that conflicts with existing environment variables may be the reason for injection failures.

Testing done

No logic changes - just error output. Tests already exist for this functionality.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
    • None
  • Link to relevant pull requests, esp. upstream and downstream changes
    • None
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue
    • Existing tests cover these lines

@matthewchivers matthewchivers requested a review from a team as a code owner June 18, 2024 16:11
@matthewchivers
Copy link
Author

matthewchivers commented Jun 28, 2024

Is there anything more that I need to do to get this looked at please?

Perhaps I needed to approach this differently? I'm unfamiliar with contribution guidelines on this project.

@matthewchivers
Copy link
Author

matthewchivers commented Sep 11, 2024

Hi @NotMyFault, I’ve noticed you’ve been active recently. When you have a moment, could you please take a look at this PR? Any feedback or guidance on how I can help move this forward would be much appreciated. Thanks in advance!

@matthewchivers matthewchivers deleted the improve-error-msg branch November 20, 2024 10:08
@matthewchivers
Copy link
Author

Closing, as I don't wish to chase this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant