Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-65462] Do NOT trigger jobs for changes that status != GerritChangeStatus.NEW #432

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[JENKINS-65462] Do NOT trigger jobs for changes that status != GerritChangeStatus.NEW #432

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
509cfc6
FIX: Do NOT trigger jobs for those status!= GerritChangeStatus.NEW
Apr 25, 2021
8433dcf
Merge branch 'jenkinsci:master' into bugfix/JENKINS-65462
chenhuahuan Sep 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
import com.sonyericsson.hudson.plugins.gerrit.trigger.version.GerritVersionChecker;
import com.sonymobile.tools.gerrit.gerritevents.GerritHandler;
import com.sonymobile.tools.gerrit.gerritevents.GerritQueryHandler;
import com.sonymobile.tools.gerrit.gerritevents.dto.GerritChangeStatus;
import com.sonymobile.tools.gerrit.gerritevents.dto.attr.Approval;
import com.sonymobile.tools.gerrit.gerritevents.dto.attr.Change;
import com.sonymobile.tools.gerrit.gerritevents.dto.attr.PatchSet;
Expand Down Expand Up @@ -925,7 +926,13 @@ public boolean equals(Object obj) {
* @return true if we should.
*/
private boolean isChangeInteresting(Change change, GerritProject project, GerritQueryHandler gerritQueryHandler) {

boolean shouldTrigger = false;

if (change.getStatus() != GerritChangeStatus.NEW ) {
return shouldTrigger; // return false immediately if it's a non-NEW status change
}

boolean containsFilePathsOrForbiddenFilePaths = ((project.getFilePaths() != null
&& project.getFilePaths().size() > 0)
|| (project.getForbiddenFilePaths() != null && project.getForbiddenFilePaths().size() > 0));
Expand Down