-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-70897] Add support for personal access token authentication #1104
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the pull request.
Can you describe the testing that you performed to confirm that the change works as expected?
src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
Outdated
Show resolved
Hide resolved
I've tested the changes by creating an organizational folder for project auto discovery. The token added in there as credentials discovers all projects/branches as expected, but the builds weren't able to checkout the repository. Tested it with a Windows build agent and Kubernetes cloud agents. I'm also working on a PR in the git-plugin to pass the credentials in here. Otherwise this change will not work at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need a corrsponding change for jgit
, or is this unsupported there?
if unsupported should this not be called somewhere?
I think that there is an alternate implementation technique that would add support for a standard credential and would work with both JGit and command line git. |
Please kindly add these changes. |
JENKINS-70897 - Add support for personal access token authentication
On Bitbucket Datacenter/Cloud and Azure it is required to use personal access tokens instead of username/password authentication.
Resolves jenkinsci/bitbucket-branch-source-plugin#716
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that apply