Turn source image project into a combobox. #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous select was too restrictive as it didn't allow to provide a value for this field other than the project where the VM is to be scheduled. Source image could be located in a different project and shared to the project where the VM is scheduled. Also removed usage of anonymous inner class when a simpler alternative is available.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/com/google/jenkins/plugins/computeengine/InstanceConfiguration.java
Fixed
Show fixed
Hide fixed
| @@ -834,16 +831,12 @@ | |||
| } | |||
| } | |||
|
|
|||
| public ListBoxModel doFillBootDiskSourceImageProjectItems( | |||
| @AncestorInPath Jenkins context, | |||
| public ComboBoxModel doFillBootDiskSourceImageProjectItems( | |||
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation Warning
gbhat618
approved these changes
Jan 9, 2025
jglick
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous select was too restrictive as it didn't allow to provide a value for this field other than the project where the VM is to be scheduled.
Source image could be located in a different project and shared to the project where the VM is scheduled.
Also removed usage of anonymous inner class when a simpler alternative is available.
Testing done
Submitter checklist