No error #38
Open
No error #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -372,7 +374,18 @@ private Stack waitForStackToBeCreated() throws TimeoutException { | |||
| private void printStackEvents() { | |||
| DescribeStackEventsRequest r = new DescribeStackEventsRequest(); | |||
| r.withStackName(getExpandedStackName()); | |||
| DescribeStackEventsResult describeStackEvents = amazonClient.describeStackEvents(r); | |||
| int count = 0; | |||
There was a problem hiding this comment.
I think count should be set to 1 here, so that the initial retry is not:
Got an error getting stack status, retrying 0 out of 3 times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to use this plugin and had no issues, then we switched to running it in a docker container and started getting errors like:
com.ctc.wstx.exc.WstxIOExceptionwhich when run in debug would point to a timeout from aws. When I run the container locally I could not reproduce the problem. but when running on another host in our environment I could reproduce it. This pull request adds a retry around the call that was failing. Another fix would be to remove it, as it appears to not be necessary, but I went the route of least change. We have started to use this version in our environment and the issue has gone away as a second retry works.My .editorconfig removed a lot of unecessary whitespace