[JENKINS-73964] Extract event handlers in MultiJobTestResults/index.jelly
#376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
changed the title
MultiJobTestResults/index.jelly
basil
reviewed
Oct 22, 2024
| <l:icon src="symbol-remove-outline plugin-ionicons-api" class="icon-sm"/> | ||
| </a> | ||
| <st:nbsp/> | ||
|
|
There was a problem hiding this comment.
Please revert this hunk, as it is cluttering the diff with unrelated formatting changes (increasing risk and decreasing reviewability).
| <a href="${rootURL}/${report.child.url}testReport/${f.getRelativePathFrom(report.result)}"> | ||
| <st:out value="${f.fullName}"/> | ||
| <st:nbsp/> | ||
| <j:forEach var="badge" items="${f.testActions}"> | ||
| <st:include it="${badge}" page="badge.jelly" optional="true"/> | ||
| </j:forEach> | ||
| </a> | ||
|
|
src/main/resources/com/tikal/jenkins/plugins/multijob/MultiJobTestResults/index.jelly
Outdated
Show resolved
Hide resolved
...esources/com/tikal/jenkins/plugins/multijob/MultiJobTestResults/show-hide-failure-summary.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-73964
Very similar JS extraction to:
Testing done
-Using same steps for testing as #375
statusQuo
csp-report-only
csp-restrictive
Submitter checklist