-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dawidd6/action-send-mail action to v4 #9996
base: master
Are you sure you want to change the base?
Conversation
@@ -16,7 +16,7 @@ jobs: | |||
discourse-author-username: jenkins-release-bot | |||
discourse-category: 23 | |||
- name: Post on mailing list | |||
uses: dawidd6/action-send-mail@v3 | |||
uses: dawidd6/action-send-mail@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use hash instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daniel-beck For what reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General good practice, see e.g. https://github.com/ossf/scorecard/blob/51f31c9882b6e5998e0df571096147a99842092b/docs/checks.md#pinned-dependencies for OpenSSF's take on this.
Previously done elsewhere in #7584.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that not a pre-existing issue? How is this PR introducing a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daniel-beck Any thoughts on the above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nonblocking comment, so feel free to merge despite this.
Changing a dependency version in the wrong format to a dependency version in the wrong format seems silly though, preexisting problem or not.
This PR contains the following updates:
v3
->v4
Release Notes
dawidd6/action-send-mail (dawidd6/action-send-mail)
v4
Compare Source
What's Changed
Full Changelog: dawidd6/action-send-mail@v3.12.0...v4
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.