Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73825] ldap allows insecure configurations #300

Merged

Conversation

vwagh-dev
Copy link
Contributor

@vwagh-dev vwagh-dev commented Sep 27, 2024

See JENKINS-73825
In FIPS mode, now LDAP don't allows the insecure configuration. Also it shows the error messages in case of insecure ldap url/ short password

Testing

Manually testing is done with below scenarios

  1. Configure insecure ldap url & error should thrown + form data should not be saved ✅
  2. Configure secure ldap url & error should thrown + form data should not be saved ✅
  3. In advance configuration manager password less than 14 is not allowed ✅
  4. CASC configuration unit test to load the ldap configuration i.e. CasCFipsTest
    • When configuration has secure url + valid password length
    • When configuration has insecure url/valid password length CasCFipsTest.configure_ldap_for_invalid
  5. UI Integration Test ✅
    • For Insecure ldap server url
    • For invalid manager password size

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@vwagh-dev vwagh-dev marked this pull request as ready for review October 1, 2024 11:16
@vwagh-dev vwagh-dev requested review from a team as code owners October 1, 2024 11:16
Copy link
Member

@rsandell rsandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for some small nits and cost saving measures.

Copy link

@PereBueno PereBueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@rsandell rsandell merged commit 92d97ab into jenkinsci:master Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants