Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use build parameters as resource, label and number. #214

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Use build parameters as resource, label and number. #214

wants to merge 14 commits into from
+467 −65

Conversation

cfoote
Copy link

@cfoote cfoote commented Aug 25, 2020

Allows build parameters to specify resource names (issue #159), labels and number (issue #202) in Freestyle builds.

Used the code for PR #33 as a base and fixed the issues raised.

  • Running in parallel.
  • Parameter expansion is handled with the standard Jenkins '${parameter}' style.
  • The label can also be specified with a parameter.

Tests added too.

@gregoryduckworth
Copy link

gregoryduckworth commented Dec 23, 2020 •
edited
Loading

Would love to see this implemented.

@worroc
Copy link

worroc commented Mar 18, 2021

Waiting for that feature from 2016.

@jimklimov jimklimov added got conflicts Feature/fix may be reasonable, but can not be merged cleanly variables for lock aspects freestyle vs pipeline Sometimes one use-case is better exposed than another; this label helps note where we need to level labels Feb 2, 2022
@mPokornyETM mPokornyETM added the Triage Need to clarify, remove, close or whatever to clean up open issues / PRs label Feb 1, 2023
@mPokornyETM mPokornyETM added this to the Triage milestone Feb 1, 2023
@fho
Copy link

fho commented Oct 9, 2023

@cfoote do you maybe have time to resolve the merge conflicts.

It would be awesome if we could get this feature in.

@cfoote cfoote requested a review from a team as a code owner January 29, 2024 10:48
@mPokornyETM
Copy link
Contributor

please let a look on the failed test cases. Thx

@mPokornyETM
Copy link
Contributor

pls provide documentation in the readme file. This is nice feature and it shall be not "hidden"
everthink else LGTM

@mPokornyETM mPokornyETM added java Pull requests that update Java code localization and removed got conflicts Feature/fix may be reasonable, but can not be merged cleanly Triage Need to clarify, remove, close or whatever to clean up open issues / PRs labels Jan 29, 2024
@mPokornyETM mPokornyETM modified the milestones: Triage, Feature committed Feb 25, 2024
@fho
Copy link

fho commented May 7, 2024

@mPokornyETM could you please have another look?

@mPokornyETM
Copy link
Contributor

@mPokornyETM could you please have another look?

did you implemented my comments ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement freestyle vs pipeline Sometimes one use-case is better exposed than another; this label helps note where we need to level java Pull requests that update Java code localization variables for lock aspects wontfix
Projects
None yet
Milestone
Feature committed
Development

Successfully merging this pull request may close these issues.
7 participants
@cfoote @gregoryduckworth @worroc @fho @mPokornyETM @TobiX @jimklimov