Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings for spotbugs 4.8.3 #611

Merged

Conversation

MarkEWaite
Copy link
Contributor

Suppress warnings for spotbugs 4.8.3

Plugin pom 4.77 needs this change to resolve new spotbugs warnings that will be reported by spotbugs 4.8.3 and later.

Confirmed that the spotbugs warnings are visible when using the 4.77-SNAPSHOT plugin pom before this change. With this change, the spotbugs warnings are no longer visible.

Testing done

Confirmed that spotbugs is silent with plugin pom 4.77 after this change.

Can skip the changelog, since this is not visible to users.

Proposed upgrade guidelines

N/A

Localizations

  • N/A

Submitter checklist

  • The Jira / Github issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • The changelog generator for plugins uses the pull request title as the changelog entry.
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during the upgrade.
  • There is automated testing or an explanation that explains why this change has no tests.
  • New public functions for internal use only are annotated with @NoExternalUse. In case it is used by non java code the Used by {@code <panel>.jelly} Javadocs are annotated.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease the future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.
  • Any localizations are transferred to *.properties files.
  • Changes in the interface are documented also as examples.

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There is at least one (1) approval for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically. See also release-drafter-labels.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • java code changes are tested by automated test.

Plugin pom 4.77 needs this change to resolve new spotbugs warnings
that will be reported by spotbugs 4.8.3 and later.

Confirmed that the spotbugs warnings are visible when using the
4.77-SNAPSHOT plugin pom before this change. With this change, the
spotbugs warnings are no longer visible.
@MarkEWaite MarkEWaite requested a review from a team as a code owner January 16, 2024 00:56
@MarkEWaite
Copy link
Contributor Author

CI failure is due to a performance issue / timeout that the infrastructure team is investigating. Refer to:

@mPokornyETM
Copy link
Contributor

Strange.
@MarkEWaite my you pls replay the job, I dont have the permissions in the Jenkins.
It looks like the spotbugs has stuck.

[164](https://ci.jenkins.io/job/Plugins/job/lockable-resources-plugin/job/PR-611/1/pipeline-console/?start-byte=0&selected-node=88#log-164)
02:57:25  [INFO] --- spotbugs:4.7.3.6:spotbugs (spotbugs) @ lockable-resources ---
[165](https://ci.jenkins.io/job/Plugins/job/lockable-resources-plugin/job/PR-611/1/pipeline-console/?start-byte=0&selected-node=88#log-165)
03:01:56  Sending interrupt signal to process

@lemeurherve
Copy link
Member

I replayed the build, it took 25min.

@mPokornyETM mPokornyETM merged commit 47aff0d into jenkinsci:master Jan 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants