Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from EE 8 to EE 9 #743

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Migrate from EE 8 to EE 9 #743

merged 1 commit into from
Jan 17, 2025

Conversation

basil
Copy link
Member

@basil basil commented Jan 17, 2025

No description provided.

@basil basil added the internal label Jan 17, 2025
@basil basil requested a review from a team as a code owner January 17, 2025 01:33
@MarkEWaite MarkEWaite merged commit c7684f8 into jenkinsci:master Jan 17, 2025
17 checks passed
@mPokornyETM
Copy link
Contributor

Sorry guys, but migth somebody explaint to me why we need this changes? There is no issue linked, no explenation (PR description)

@MarkEWaite
Copy link
Contributor

Sorry guys, but might somebody explain to me why we need this changes? There is no issue linked, no explanation

Sure! Thanks for asking. The upgrade from Jenkins 2.462.3 to Jenkins 2.479.1 includes:

  • Spring Security 5 upgraded to Spring Security 6
  • Java EE 8 upgraded to Jakarta EE 9
  • Eclipse Jetty 10 upgraded to Eclipse Jetty 12
  • Java 11 required minimum Java version upgraded to Java 17 minimum required Java version

Those upgrades add new classes and new methods. A compatibility layer was added in Jenkins core in order to retain compatibility with the prior implementations while using the new classes and methods. That compatibility layer is a large body of code that we want to eventually remove (as much as we can). In order to remove that compatibility layer, plugins need to be updated to use the new classes and methods instead of using the compatibility layer.

Prior releases of the lockable resources plugin worked as expected on Jenkins 2.479.1 because they relied on the compatibility layer in Jenkins 2.479.1. This pull request adapts the plugin to use the new methods and new classes rather than relying on the compatibility layer. Similar changes will be needed in all Jenkins plugins that rely on the compatibility layer.

The key goal of this pull request is to complete the Spring Security 6.x upgrade project in the source code of the lockable resources plugin. The change switches from:

This pull request is one of many that have been submitted to complete the Spring Security 6 upgrade one plugin at a time. Many more pull requests will be submitted like this one over the next 6-9 months.

@mPokornyETM
Copy link
Contributor

Similar changes will be needed in all Jenkins plugins that rely on the compatibility layer.

thats a huge effort. I wihs you all many luck. You will need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants