Adjust for script security #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
246c635 updates the bom which updates script security plugin from 1366 to 1367 and it can now throw a FormException.
|
That comes from jenkinsci/script-security-plugin#585 which was updated while upgrading the bom in #228 228 |
|
Thanks!!! |
hashar
added a commit
to hashar/postbuildscript-plugin
that referenced
this pull request
Nov 5, 2024
In jenkinsci#229, I have adjust the source code to take in account the scripty security plugin can now throw a FormException. I only checked it with `mvn compile` and missed that tests were not compiled and had to be adjusted. Tested locally with `mvn verify`
|
I only ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
246c635 updates the bom which updates script security plugin from 1366 to 1367 and it can now throw a FormException.
Before submitting a pull request, please make sure the following is done:
master.mvn clean verify).mvn hpi:runand go to http://localhost:8080/jenkins/ to test your changes. Add a job that produces your bug / feature scenario.