Don't call Jenkins.get() within loop

jenkinsci · Nov 26, 2023 · 7e3f6e6 · 7e3f6e6
1 parent 8dab3b1
commit 7e3f6e6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/prometheus/JenkinsStatusCollector.java b/src/main/java/org/jenkinsci/plugins/prometheus/JenkinsStatusCollector.java
@@ -16,15 +16,15 @@ public class JenkinsStatusCollector extends Collector {
     public List<MetricFamilySamples> collect() {
 
         CollectorFactory factory = new CollectorFactory();
-
+        Jenkins jenkins = Jenkins.get();
         List<MetricCollector<Jenkins, ? extends Collector>> collectors = new ArrayList<>();
 
         collectors.add(factory.createJenkinsCollector(CollectorType.JENKINS_VERSION_INFO_GAUGE, new String[]{}));
         collectors.add(factory.createJenkinsCollector(CollectorType.JENKINS_UP_GAUGE, new String[]{}));
         collectors.add(factory.createJenkinsCollector(CollectorType.JENKINS_UPTIME_GAUGE, new String[]{}));
         collectors.add(factory.createJenkinsCollector(CollectorType.NODES_ONLINE_GAUGE, new String[]{"node"}));
 
-        collectors.forEach(c -> c.calculateMetric(Jenkins.get(), new String[]{}));
+        collectors.forEach(c -> c.calculateMetric(jenkins, new String[]{}));
 
         return collectors.stream()
                 .map(MetricCollector::collect)