chore: bump simple disk usage to include new metric #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like a good improvement. Thank you, looking forward for the PR 👍 |
|
@meiswjn. Did you already start with the implementation? Otherwise I would implement that feature today and close this PR? |
|
Hey @Waschndolos, not yet - that would be wonderful! Thanks! |
|
Ok perfect. I've tracked it here: #590. Closing this PR then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new disk metric for file count to prometheus metrics plugin (introduced in #jenkinsci/cloudbees-disk-usage-simple-plugin#92)
Changes proposed
Checklist
Notify
@Waschndolos