Skip to content

Commit

Permalink
JENKINS-73941 - Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: michael cirioli <[email protected]>
  • Loading branch information
jgarciacloudbees and mikecirioli authored Oct 24, 2024
1 parent 4cbf832 commit af7eee1
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ operations to whitelist. Operations which change state of persisted objects (suc
Jenkins jobs) should generally be denied. Most `getSomething` methods are harmless.

In case of highly secured environments, where only sandbox scripts are allowed, the
option "Force to use the Sandbox globally in the system" allows forcing the use of the
option "Force the use of the sandbox globally in the system" allows forcing the use of the
sandbox globally in the system and will block the creation of new items in the
"In-process Script Approval" screen.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ ScriptApprovalLink.outstandingSignature={0} signatures pending approval
ScriptApprovalLink.outstandingClasspath={0} classpath entries pending approval
ScriptApprovalLink.dangerous={0} approved dangerous signatures
ScriptApproval.PipelineMessage=A Jenkins administrator will need to approve this script before it can be used
ScriptApproval.ForceSandBoxMessage=Running Scripts out of the Sandbox is not allowed in the system
ScriptApproval.ForceSandBoxMessage=Running scripts out of the sandbox is not allowed in the system
UnapprovedUsage.NonApproved=script not yet approved for use
UnapprovedUsage.ForceSandBox=Running Scripts out of the Sandbox is not allowed in the system
UnapprovedUsage.ForceSandBox=Running scripts out of the sandbox is not allowed in the system
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:l="/lib/layout" xmlns:f="/lib/form">
<f:section title="${%System Sandbox enablement}">
<f:entry field="forceSandbox" title="${%Force to use the Sandbox globally in the system}">
<f:entry field="forceSandbox" title="${%Force the use of the sandbox globally in the system}">
<f:checkbox/>
</f:entry>
</f:section>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div>
<p>Controls whether the "Use Groovy Sandbox" is shown in the system to users without Overall/Administer permission.</p>
<p>This can be used to get a better UX in highly secured environments where all pipelines and other logics are
<p>This can be used to simplify the UX in highly secured environments where all pipelines and other logics are
required to run in the sandbox (ie. running arbitrary code is never approved)</p>
</div>

0 comments on commit af7eee1

Please sign in to comment.