Skip to content

Commit

Permalink
JENKINS-73941 - Avoid disabling the ScriptApproval screen with forceS…
Browse files Browse the repository at this point in the history
…andbox mode enabled
  • Loading branch information
jgarciacloudbees committed Oct 17, 2024
1 parent 7beb61e commit c621bd4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ Jenkins jobs) should generally be denied. Most `getSomething` methods are harmle

In case of highly secured environments, where only sandbox scripts are allowed, the
option "Force to use the Sandbox globally in the system" allows forcing the use of the
sandbox globally in the system and will disable the "In-process Script Approval" screen.
sandbox globally in the system and will block the creation of new items in the
"In-process Script Approval" screen.

### ACL-aware methods
Be aware however that even some “getter” methods are designed to check specific
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
@Extension public final class ScriptApprovalLink extends ManagementLink {

@Override public String getIconFileName() {
if (ScriptApproval.get().isForceSandbox() || ScriptApproval.get().isEmpty()) {
if (ScriptApproval.get().isEmpty()) {
return null;
}
return "symbol-edit-note";
Expand Down

0 comments on commit c621bd4

Please sign in to comment.