[JENKINS-75012] Pre-compile Handlebars templates #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-75012
All of the Handlebars stuff is now pre-compiled in built time instead of run time. This includes templates, partials and helpers.
Depends on #122. I'll rebase this PR when that one is merged.
Testing done
There's not much to show in "Before". In report-only mode 15+ violations are caught coming from handlebars-2.0.0.js because of runtime template compilation. In restrictive mode page doesn't render at all.
After the change
Proposed upgrade guidelines
N/A
Submitter checklist
@NoExternalUse
. In case it is used by non java code theUsed by {@code <panel>.jelly}
Javadocs are annotated.eval
to ease the future introduction of Content Security Policy (CSP) directives (see documentation).Maintainer checklist
Before the changes are marked as
ready-for-merge
: