Skip to content
This repository has been archived by the owner on May 14, 2022. It is now read-only.

Rename usage of the term 'slave' to 'agent' #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkemmerz
Copy link

@mkemmerz mkemmerz commented Oct 3, 2021

https://issues.jenkins.io/browse/JENKINS-42844

The wording of "slave" has been changed to the term "agent". This was done for classes, methods, config and JAR files.
No bug fixing was done and no new feature was introduced.

  • [x ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x ] Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Tests are still working

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good start but it will lead to regressions on older agents that use "slave.xml". Ideally there should be migration logic.

Also some unrestricted classes are renamed, it is likely to caused regressions in downstream, e.g. in https://github.com/jenkinsci/graphql-server-plugin/blob/6fffb7ecb178ae4804ce32bee91185f64c4abaa6/src/test/java/io/jenkins/plugins/graphql/MockClassUtils.java . It is not a big deal since it is unit test but there might be similar issues in 3rd party plugins

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants