Skip to content

Commit

Permalink
Merge pull request #196 from Ladyprowess/patch-1
Browse files Browse the repository at this point in the history
Make a comment more inclusive
  • Loading branch information
jglick authored Jul 19, 2022
2 parents 4c32a04 + cc73ad9 commit 8d89be9
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public final class ReadFileStep extends Step {
private String encoding;

@DataBoundConstructor public ReadFileStep(String file) {
// Normally pointless to verify that this is a relative path, since shell steps can anyway read and write files anywhere on the slave.
// Normally pointless to verify that this is a relative path, since shell steps can anyway read and write files anywhere on the agent.
// Could be necessary in case a plugin installs a {@link LauncherDecorator} which keeps commands inside some kind of jail.
// In that case we would need some API to determine that such a jail is in effect and this validation must be enforced.
// But just checking the path is anyway not sufficient (due to crafted symlinks); would need to check the final resulting path.
Expand Down

0 comments on commit 8d89be9

Please sign in to comment.