Merge pull request #201 from jglick/RetryStep.count

Add form validation for `RetryStep.count`
jenkinsci · Jul 7, 2022 · fe95552 · fe95552
2 parents c6812bb + 067e5ef
commit fe95552
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStep.java b/src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStep.java
@@ -27,9 +27,11 @@
 import edu.umd.cs.findbugs.annotations.NonNull;
 import hudson.Extension;
 import hudson.model.TaskListener;
+import hudson.util.FormValidation;
 import java.util.Collections;
 import java.util.Set;
 import org.kohsuke.stapler.DataBoundConstructor;
+import org.kohsuke.stapler.QueryParameter;
 
 /**
  * Executes the body up to N times.
@@ -83,6 +85,16 @@ public Set<? extends Class<?>> getRequiredContext() {
             return Collections.singleton(TaskListener.class);
         }
 
+        public FormValidation doCheckCount(@QueryParameter int count) {
+            if (count < 1) {
+                return FormValidation.error("Count must be positive.");
+            } else if (count == 1) {
+                return FormValidation.warning("Count of one means that the retry step has no effect. Use ≥2.");
+            } else {
+                return FormValidation.ok();
+            }
+        }
+
     }
 
 }