Merge pull request #936 from jglick/staticInterfaceMethod-JENKINS-73031

[JENKINS-73031] Print hint that a `static` `interface` method may be to blame
jenkinsci · Sep 26, 2024 · dc9d3ae · dc9d3ae
2 parents 25ee0f3 + 492a2b5
commit dc9d3ae
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThreadGroup.java b/plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThreadGroup.java
@@ -435,6 +435,16 @@ private boolean run() {
                     if (fn != null) {
                         t.head.get().addAction(new ErrorAction(error));
                     }
+                    if (error instanceof VerifyError) {
+                        var msg = error.getMessage();
+                        if (msg != null && msg.contains("Illegal type in constant pool")) {
+                            try {
+                                execution.getOwner().getListener().getLogger().println("May be JENKINS-73031: calling static interface methods from Groovy is not currently supported by Jenkins");
+                            } catch (IOException x) {
+                                LOGGER.log(Level.WARNING, null, x);
+                            }
+                        }
+                    }
                 }
 
                 if (!t.isAlive()) {

diff --git a/plugin/src/test/java/org/jenkinsci/plugins/workflow/cps/CpsScriptTest.java b/plugin/src/test/java/org/jenkinsci/plugins/workflow/cps/CpsScriptTest.java
@@ -75,6 +75,14 @@ public void evaluateShallSandbox() throws Exception {
         r.assertLogContains("Scripts not permitted to use new java.io.File java.lang.String", b);
     }
 
+    @Issue("JENKINS-73031")
+    @Test public void staticInterfaceMethod() throws Exception {
+        var p = r.createProject(WorkflowJob.class);
+        p.setDefinition(new CpsFlowDefinition("def x = List.of(1, 2, 3); echo(/x=$x/)", false));
+        var b = r.buildAndAssertStatus(Result.FAILURE, p);
+        r.assertLogContains("JENKINS-73031", b);
+    }
+
     @Test public void blockRun() throws Exception {
         WorkflowJob p = r.createProject(WorkflowJob.class);
         p.setDefinition(new CpsFlowDefinition("run(null, ['test'] as String[])\n", true));