Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CpsFlowExecution: parseScript(): log "Method Too Large" situations more readably #817

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
390427a
CpsFlowExecution: parseScript(): log "Method Too Large" situations mo…
jimklimov Jun 6, 2023
c438ebd
Merge branch 'master' into logging-exMTL
jimklimov Dec 11, 2023
93d4621
Merge remote-tracking branch 'upstream/master' into logging-exMTL
jimklimov Mar 5, 2024
b91c7f6
CpsFlowExecution: import groovyjarjarasm.asm.MethodTooLargeException …
jimklimov Mar 5, 2024
28cb0c3
CpsScriptTest: add methodTooLargeExceptionFabricated() and methodTooL…
jimklimov Mar 5, 2024
df2b78f
CpsFlowExecution, CpsScriptTest: handle also MultipleCompilationError…
jimklimov Mar 5, 2024
ffe1f1a
CpsScriptTest.methodTooLargeExceptionRealistic(): reduce iteration co…
jimklimov Mar 5, 2024
fa95de7
CpsFlowExecution.parseScript(): handle MethodTooLargeException withou…
jimklimov Mar 5, 2024
66afa75
CpsFlowExecution.parseScript(): MethodTooLargeException: actionable s…
jimklimov Mar 5, 2024
74a125c
CpsScriptTest.methodTooLargeExceptionRealistic(): update comments and…
jimklimov Mar 5, 2024
5a50a57
CpsScriptTest.methodTooLargeExceptionRealistic(): decouple maxStagesM…
jimklimov Mar 5, 2024
d781a3b
Merge branch 'master' into logging-exMTL
jimklimov Apr 24, 2024
89bbd40
Update plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlo…
jimklimov Jun 11, 2024
38cc476
Merge branch 'master' into logging-exMTL
jimklimov Jun 11, 2024
0fc23a5
Merge branch 'master' into logging-exMTL
jimklimov Jun 24, 2024
92aadc9
CpsFlowExecution: restore the multi-catch for "RuntimeException | Error"
jimklimov Jun 26, 2024
8c36e27
Revert "Update plugin/src/main/java/org/jenkinsci/plugins/workflow/cp…
jimklimov Jun 26, 2024
82470d2
CpsFlowExecution: restore the write into server log, but only at FINE…
jimklimov Jun 26, 2024
db51a8a
CpsFlowExecution: comment that the remaining case is "ecCount == 1 ex…
jimklimov Jun 26, 2024
20213ea
CpsFlowExecution: recognize also CpsCompilationErrorsException for Me…
jimklimov Jun 26, 2024
f23b610
CpsFlowExecution, CpsScriptTest: recognize also Groovy (JSL step or c…
jimklimov Jun 26, 2024
21a3f8d
CpsFlowExecution: introduce METHOD_TOO_LARGE_LOGGER for separated log…
jimklimov Jun 27, 2024
47a5e84
CpsFlowExecution: annotate what we post into METHOD_TOO_LARGE_LOGGER
jimklimov Jun 27, 2024
2adbecf
CpsFlowExecution: refactor whole reportSuspectedMethodTooLarge() magi…
jimklimov Jun 28, 2024
5954624
CpsFlowExecution: parseScript(): IDEA complains for "throw reportSusp…
jimklimov Jun 28, 2024
dac4ca6
CpsScript: getProperty(): involve CpsFlowExecution.reportSuspectedMet…
jimklimov Jun 28, 2024
4126b11
CpsFlowExecution: reportSuspectedMethodTooLarge(): fix indentations a…
jimklimov Jun 28, 2024
b078e7a
CpsFlowExecution: reportSuspectedMethodTooLarge(): when returning sho…
jimklimov Jun 28, 2024
b02afc3
CpsFlowExecution: reportSuspectedMethodTooLarge(): xStr should not in…
jimklimov Jun 28, 2024
5336cbe
CpsFlowExecution: reportSuspectedMethodTooLarge(): at least CpsCompil…
jimklimov Jun 28, 2024
4e19e1f
CpsFlowExecution: reportSuspectedMethodTooLarge(): describe what we s…
jimklimov Jun 28, 2024
93adf33
CpsFlowExecution: reportSuspectedMethodTooLarge(): document MTLE_CLAS…
jimklimov Jun 28, 2024
a512368
CpsFlowExecution: reportSuspectedMethodTooLarge(): overflowedClassNam…
jimklimov Jun 28, 2024
bfa34cb
CpsFlowExecution: reportSuspectedMethodTooLarge(): support also pipel…
jimklimov Jun 28, 2024
2fd7299
CpsFlowExecution: reportSuspectedMethodTooLarge(): wrap original log …
jimklimov Jun 28, 2024
c5e79da
CpsFlowExecution: reportSuspectedMethodTooLarge(): refactor actionabl…
jimklimov Jun 28, 2024
4d39666
CpsFlowExecution: reportSuspectedMethodTooLarge(): refactor overflowe…
jimklimov Jun 28, 2024
4f5ab70
CpsFlowExecution: reportSuspectedMethodTooLarge(): match by *short* o…
jimklimov Jun 28, 2024
9491ce1
CpsFlowExecution: reportSuspectedMethodTooLarge(): wrap original log …
jimklimov Jun 28, 2024
99362bc
CpsFlowExecution: reportSuspectedMethodTooLarge(): comment about "int…
jimklimov Jun 28, 2024
343c5da
CpsFlowExecution: reportSuspectedMethodTooLarge(): do not hijack mtlE…
jimklimov Jun 28, 2024
82edfc1
CpsFlowExecution: reportSuspectedMethodTooLarge(): avoid extra blank …
jimklimov Jun 28, 2024
337cc4e
CpsScriptTest: methodTooLargeExceptionRealistic(): expect updated wor…
jimklimov Jun 28, 2024
1ea2ffe
Merge branch 'master' into logging-exMTL
jimklimov Jan 31, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -632,11 +632,15 @@ private CpsScript parseScript() throws IOException {
trusted = new CpsGroovyShellFactory(this).forTrusted().build();
shell = new CpsGroovyShellFactory(this).withParent(trusted).build();

s = (CpsScript) shell.reparse("WorkflowScript",script);
s = (CpsScript) shell.reparse("WorkflowScript", script);

for (Entry<String, String> e : loadedScripts.entrySet()) {
shell.reparse(e.getKey(), e.getValue());
}
} catch (groovyjarjarasm.asm.MethodTooLargeException x) {
jimklimov marked this conversation as resolved.
Show resolved Hide resolved
LOGGER.log(Level.SEVERE, "FAILED to parse WorkflowScript (the pipeline script) due to MethodTooLargeException: " + x.toString());
jimklimov marked this conversation as resolved.
Show resolved Hide resolved
jimklimov marked this conversation as resolved.
Show resolved Hide resolved
closeShells();
throw x;
} catch (RuntimeException | Error x) {
closeShells();
throw x;
Expand Down