-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update appearance of editor #946
base: master
Are you sure you want to change the base?
Conversation
I expect that nobody will find the new link location in the description. Could it be made more visible? |
@@ -1,4 +0,0 @@ | |||
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whilst this was not the best help - it did at least prompt users where to look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change look one to me. Have not run the pr in any circumstances context (proprietary or other.)
ATH appears to be unaffected.
Will wait to give @daniel-beck a chance to rereview
Seems fine with the link restored. The tiny resize handle seems like quite a step back though from the nonstandard resize line at the bottom though, hitting that is fairly difficult. It seems about a quarter of the size of a normal textarea's (e.g., cron) resize handle? Additionally there's a 1px area in the border where I can click on the control and get the new highlight/focus animation, but it's not focused afterwards. Regular textareas don't have that (nit, obviously). |
Thanks! Fixed the resize handle, it was a little too inset for some reason. Couldn't find a simple fix for the 1px issue however :/ |
Resize handle size is a lot better now, thanks for iterating there. The 1px issue was a nit anyway so no big deal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not a maintainer, just org owner.)
This PR sets out to update the appearance of the pipeline editor, updating it to the Jenkins variables (such as the color palette, fonts) for consistency and making it a little larger too.
Before
After
Key changes
250px
to350px
Testing done
Submitter checklist