[JENKINS-27394] Collapsible sections in log #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
Particularly useful in jenkinsci/parallel-test-executor-plugin#20. |
| private final String id; | ||
|
|
||
| private ShowHideNote(String id, int length) { | ||
| super("#", length); |
There was a problem hiding this comment.
Might as well use "#" + id here and add an a tag in logNodeMessage, allowing us to create direct links to the section—useful for getLogURL in jenkinsci/workflow-basic-steps-plugin#2, for example.
|
Putting this on hold until JENKINS-38381 is done. |
jglick
commented
Sep 26, 2016
| /** | ||
| * Encodes the block-scoped nesting of a step. | ||
| */ | ||
| public class NestingNote extends ConsoleNote<Run<?,?>> { |
There was a problem hiding this comment.
🐛 needs to be Object to avoid breaking per-step LogAction display
jglick
added a commit
to jglick/workflow-job-plugin
that referenced
this pull request
Oct 10, 2016
|
Closing in favor of #27. |
jglick
added a commit
to jglick/workflow-job-plugin
that referenced
this pull request
Oct 12, 2016
…y encompassing all of the functionality of jenkinsci#21.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-27394
Downstream of #20.
I initially thought to add visual bounding boxes, as the Collapsing Console Sections plugin does. But this would not work with
parallelsteps at all, and it seemed clumsy to show bounding boxes unless you were inside a branch.A more radical alternative would be to never show multiple branches interleaved at all, and have a special control at the start of a
parallelbranch allowing you to select which branch to display. This would usually be fine, but there are also some cases where you actually want to know what happened in which order; Pipeline captures this information and it would be a shame to throw it away. The likely replacement would be to bake in the equivalent of thetimestamperwrapper so you could manually compare timestamps between branches in cases where this was important for debugging something.Note a little log cleanup in jenkinsci/workflow-support-plugin#10. The longer-term plan is to interleave all output into a single log file internally, with flow node (and perhaps timestamp) metadata captured at point of origin, and various visualizations like the annotated console log able to display the data however they prefer.
@reviewbybees