Length #33
Open
Length #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
reviewed
Mar 14, 2019
| test_that("each topic contains 24+ unique values", { | ||
| x <- letters[1:23] | ||
| expect_error(bingo(words = x), "m >= n_sq is not TRUE") | ||
| }) |
There was a problem hiding this comment.
This is a good start on something that is clearly much needed.
I'd tackle this in a separate PR because it's bit of a job. Harder than editing the README. We need to assess the viability of everything below inst/topics/ in a way that produces a decent error message, i.e. actually identifies the culprit(s), if something is wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progress on #31