Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more squares to football topic #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mharmston
Copy link

No description provided.

@AmeliaMN
Copy link
Contributor

Hey @mharmston, can you edit this PR a bit?

  • Take the testline out of july4th.R, save, and commit (with a descriptive message like "removed testline from july4th.R"). Then I think you can pr_push() again to update this pull request. You'll just see more stuff appearing in this conversation thread.
  • Update the title of this PR to be more descriptive (e.g. "add more topics to football.R")

@@ -25,5 +25,6 @@ c(
"Liberty",
"Flag",
"Patriot",
"Summer"
"Summer",
"testline"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in this file is probably unintentional? Please resolve in your branch and push or let me know if you'd prefer I update. Then I could accept the changes to the football card.

@jennybc jennybc changed the title Test update to lines 69 through 75 Add more squares to football topic Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants