New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore css keyframes animation styles #6

Open

artem-gusev-qs wants to merge 1 commit into jens-ox:main from artem-gusev-qs:main

artem-gusev-qs commented Aug 19, 2021 •

edited

Loading

Hi! Thanks for great rule, i've already clean a lot of unused styles.

But for now css keyframes animation rules parsed incorrectly
e.g.:

const useStyles = makeStyles(() => ({ 
  animatedDiv: {
    animation: '$myAnimation 1s linear',
  },
  '@keyframes myAnimation': { },
});

causes error "ESLint: Class undefined is unused(mui-unused-classes/unused-classes)", which has two problems:

We need to look for usage in other styles not in component (also as you see usage started with $ without '@Keyframes ' prefix)
Class in error has 'undefined' name because '@Keyframes myAnimation' is a key with Literal type which doesn't contain key.name property

For now I just add ignore because it blocks the rule usage.


          ignore css keyframes animation styles

fc43862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet