Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Extract shared functionality into common #17

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jerdra
Copy link
Owner

@jerdra jerdra commented Apr 12, 2022

  1. 15c1355 - move make_3d_from_4d into niviz.common.image
  2. 1e09a85 - update volume interface to match move
  3. ae3c5ca - move niviz.surface into niviz.common.surface, adjust niviz.interfaces.surface as well
  4. fd2c78b - add annotation import

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #17 (fd2c78b) into main (b428311) will decrease coverage by 2.15%.
The diff coverage is 17.14%.

❗ Current head fd2c78b differs from pull request most recent head 539cb76. Consider uploading reports for the commit 539cb76 to get more accurate results

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   59.69%   57.54%   -2.16%     
==========================================
  Files          13       15       +2     
  Lines         980     1034      +54     
==========================================
+ Hits          585      595      +10     
- Misses        395      439      +44     
Flag Coverage Δ
unittests 57.54% <17.14%> (-2.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
niviz/common/surface.py 12.24% <12.24%> (ø)
niviz/interfaces/surface.py 36.30% <12.50%> (ø)
niviz/interfaces/volume.py 69.66% <20.00%> (+2.27%) ⬆️
niviz/common/image.py 50.00% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b428311...539cb76. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant