Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: wasm target #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add: wasm target #33

wants to merge 2 commits into from

Conversation

tetuaoro
Copy link

@tetuaoro tetuaoro commented Nov 1, 2024

Hi Monsieur Chone,

I don't know if these changes work because I'm poor xD. I'm starting a new project and I want to use this crate on the client side (hydrate and csr).

Changes

I used target instead of feature config to target wasm or non-wasm because some crates already implement wasm in their crate.

Thanks for this great library and happy to contribute to your project. Let me know what you think about my impl.

EDIT: related to #11

@jeremychone
Copy link
Owner

@tetuaoro

First, thanks for the contribution.

To be honest, I am a little worried about how intrusive the WASM support will be to the code. I understand the appeal, but not being an expert in Rust/WASM, I am going to be cautious on this one.

Do these changes work for you in WASM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants