Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception support #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

grgustaf
Copy link
Contributor

No description provided.

JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson [email protected]
JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson [email protected]
Copy link

@jimmy-huang jimmy-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm besides 1 small thing, see comment

@@ -23,6 +23,9 @@ import { Breakpoint } from './breakpoint';
import { onHttpRequest } from './cdt-proxy-http';
import { JerryMessageScriptParsed } from './protocol-handler';

export type PausedReason = 'exception' | 'debugCommand' | 'other';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first | looks bolded, is it a format error of github or normal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do see that too... I think it's a font/resolution issue on our monitors. If I zoom in one click, the other one gets bolded. :)

Thanks for taking a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants