fix: FillGradient leak (pixijs#11061)

* Update FillGradient.ts * add a test
jerwolff · Nov 17, 2024 · 3d6cffa · 3d6cffa
1 parent 0ebb05d
commit 3d6cffa
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/scene/graphics/shared/fill/FillGradient.ts b/src/scene/graphics/shared/fill/FillGradient.ts
@@ -63,6 +63,8 @@ export class FillGradient implements CanvasGradient
     // TODO move to the system!
     public buildLinearGradient(): void
     {
+        if (this.texture) return;
+
         const defaultSize = FillGradient.defaultTextureSize;
 
         const { gradientStops } = this;

diff --git a/tests/graphics/GraphicsFill.tests.ts b/tests/graphics/GraphicsFill.tests.ts
@@ -2,7 +2,7 @@ import { Color } from '../../src/color/Color';
 import { Texture } from '../../src/rendering/renderers/shared/texture/Texture';
 import { FillGradient } from '../../src/scene/graphics/shared/fill/FillGradient';
 import { FillPattern } from '../../src/scene/graphics/shared/fill/FillPattern';
-import { toStrokeStyle } from '../../src/scene/graphics/shared/utils/convertFillInputToFillStyle';
+import { toFillStyle, toStrokeStyle } from '../../src/scene/graphics/shared/utils/convertFillInputToFillStyle';
 
 import type { ConvertedStrokeStyle } from '../../src/scene/graphics/shared/FillTypes';
 
@@ -152,4 +152,18 @@ describe('convertStrokeInputToStrokeStyle', () =>
             matrix: gradient.transform
         });
     });
+
+    it('should only build FillGradient once', () =>
+    {
+        const defaultStyle = getDefaultValue();
+        const gradient = new FillGradient(0, 0, 200, 0);
+
+        toFillStyle(gradient, defaultStyle);
+
+        const texture = gradient.texture;
+
+        toFillStyle(gradient, defaultStyle);
+
+        expect(texture).toBe(gradient.texture);
+    });
 });