fix: html text height (pixijs#11008)

* fix nine slice not updating after GC * add test back * fix html text height measurment --------- Co-authored-by: Zyie <[email protected]>
jerwolff · Oct 22, 2024 · 68226e0 · 68226e0
1 parent dbc8b73
commit 68226e0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/src/scene/text-html/utils/measureHtmlText.ts b/src/scene/text-html/utils/measureHtmlText.ts
@@ -1,4 +1,3 @@
-import { CanvasTextMetrics } from '../../text/canvas/CanvasTextMetrics';
 import { HTMLTextRenderData } from '../HTMLTextRenderData';
 
 import type { Size } from '../../../maths/misc/Size';
@@ -42,13 +41,11 @@ export function measureHtmlText(
 
     svgRoot.remove();
 
-    const descenderPadding = CanvasTextMetrics.measureFont(style.fontStyle).descent;
-
     // padding is included in the CSS calculation, so we need to remove it here
     const doublePadding = style.padding * 2;
 
     return {
         width: contentBounds.width - doublePadding,
-        height: contentBounds.height + descenderPadding - doublePadding,
+        height: contentBounds.height - doublePadding,
     };
 }
diff --git a/tests/renderering/text/measureHtmlText.tests.ts b/tests/renderering/text/measureHtmlText.tests.ts
@@ -1,4 +1,3 @@
-import { CanvasTextMetrics } from '../../../src/scene/text/canvas/CanvasTextMetrics';
 import { HTMLTextStyle } from '../../../src/scene/text-html/HtmlTextStyle';
 import { measureHtmlText } from '../../../src/scene/text-html/utils/measureHtmlText';
 
@@ -19,10 +18,8 @@ describe('measureHtmlText', () =>
         const style = new HTMLTextStyle();
         const size = measureHtmlText('', style);
 
-        const descent = CanvasTextMetrics.measureFont(style.fontStyle).descent;
-
         expect(size).toBeTruthy();
         expect(size.width).toBe(0);
-        expect(size.height).toBe(descent);
+        expect(size.height).toBe(0);
     });
 });