fix: If using multiview rendering, call ensureCanvasSize before rende…

…ring (pixijs#11058) * If using multiview rendering, call ensureCanvasSize before rendering (fixes pixijs#10972) * move to a prerender function --------- Co-authored-by: Mat Groves <[email protected]> Co-authored-by: Zyie <[email protected]>
jerwolff · Nov 20, 2024 · decb807 · decb807
1 parent 6a88679
commit decb807
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/rendering/renderers/gl/renderTarget/GlRenderTargetAdaptor.ts b/src/rendering/renderers/gl/renderTarget/GlRenderTargetAdaptor.ts
@@ -452,6 +452,17 @@ export class GlRenderTargetAdaptor implements RenderTargetAdaptor<GlRenderTarget
         }
     }
 
+    public prerender(renderTarget: RenderTarget)
+    {
+        const resource = renderTarget.colorTexture.resource;
+
+        // if the render target is a canvas, ensure its size matches the source
+        if (this._renderer.context.multiView && CanvasSource.test(resource))
+        {
+            this._renderer.context.ensureCanvasSize(resource);
+        }
+    }
+
     public postrender(renderTarget: RenderTarget)
     {
         // if multiView is not enabled, we don't need to do anything

diff --git a/src/rendering/renderers/shared/renderTarget/RenderTargetSystem.ts b/src/rendering/renderers/shared/renderTarget/RenderTargetSystem.ts
@@ -96,7 +96,10 @@ export interface RenderTargetAdaptor<RENDER_TARGET extends GlRenderTarget | GpuR
     finishRenderPass(renderTarget: RenderTarget): void
 
     /** called after the render pass is finished */
-    postrender?(renderTarget: RenderTarget,): void;
+    postrender?(renderTarget: RenderTarget): void;
+
+    /** called before the render main pass is started */
+    prerender?(renderTarget: RenderTarget): void;
 
     /**
      * initializes a gpu render target. Both renderers use this function to initialize a gpu render target
@@ -232,6 +235,8 @@ export class RenderTargetSystem<RENDER_TARGET extends GlRenderTarget | GpuRender
         this.rootViewPort.copyFrom(this.viewport);
         this.rootRenderTarget = this.renderTarget;
         this.renderingToScreen = isRenderingToScreen(this.rootRenderTarget);
+
+        this.adaptor.prerender?.(this.rootRenderTarget);
     }
 
     public postrender()