Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uglify-js from dependencies #341

Closed
saveman71 opened this issue Jan 14, 2019 · 1 comment · Fixed by #342
Closed

Remove uglify-js from dependencies #341

saveman71 opened this issue Jan 14, 2019 · 1 comment · Fixed by #342

Comments

@saveman71
Copy link
Contributor

Hello,

I have accord listed in my dependencies because it's used from gulp-less.
accord makes npm install [email protected] for no reason, because it's listed in dependencies and not peer or dev dependencies.

My idea of a fix would be to move uglify-js to devDependencies at it seems to be your convention, but I believe peerDependencies would be even better, correct me if I'm wrong (thus #339 is maybe related).
@jescalan
Copy link
Owner

Totally fine with moving uglify to dev deps!

@saveman71 saveman71 mentioned this issue Jan 15, 2019
Merged
jescalan pushed a commit that referenced this issue Jan 21, 2019
@saveman71 @jescalan
Move uglify-js to devdeps + fix tests (#342)
ec2d651 
Fixes #341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move uglify-js to devdeps + fix tests LaBelleAssiette/accord
2 participants
@jescalan @saveman71