Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move uglify-js to devdeps + fix tests #342

Merged
merged 2 commits into from
Jan 21, 2019
Merged

Move uglify-js to devdeps + fix tests #342

merged 2 commits into from
Jan 21, 2019

Conversation

saveman71
Copy link
Contributor

Fixes #341

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 76.258% when pulling 296eb59 on LaBelleAssiette:master into 0fced09 on jescalan:master.

@coveralls
Copy link

coveralls commented Jan 15, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 76.258% when pulling 1f3e6f1 on LaBelleAssiette:master into 0fced09 on jescalan:master.

@saveman71
Copy link
Contributor Author

Okay, this is weird, local tests were failing because of these backticks, and I had now idea where they were coming from, so I added them to the expected outputs where relevant. I'll remove them then, any idea of the origin?

@jescalan
Copy link
Owner

Yeah sometimes frameworks will update and their output will change slightly - this is normal. Thanks for fixing! This looks great - are you ready for review or still working?

@saveman71
Copy link
Contributor Author

Damn I thought that last commit was fixing the failing build but no. Once it's green I'm done.

@saveman71
Copy link
Contributor Author

@jescalan RTM for me!

@saveman71
Copy link
Contributor Author

@jescalan up! 🙂

jescalan
jescalan approved these changes Jan 21, 2019
View reviewed changes
Copy link
Owner

@jescalan jescalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks for the hustle ✨

@jescalan jescalan merged commit ec2d651 into jescalan:master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jescalan jescalan jescalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove uglify-js from dependencies
3 participants
@saveman71 @coveralls @jescalan