Allow additional (non-chef) nodes to be specified. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) by setting the munin.nodes variable. This is an array of objects, which take the same fqdn and ipaddress keys as the node search returns by default. Also this enables to reach servers hidden behind a firewall through munin native ssh.
|
FWIW |
|
This is very useful! Would be great to get this in the main fork. Note that, contrary to the comment above, this does not do the same thing as `node['munin']['server_list'] — that option is for munin-client and specifies what servers are allowed to connect. This pull request allows you to tell a munin-server to fetch information from other nodes besides those existing in your chef recipe. For example, I have one server I use as a munin server for all my other servers/clusters, rather than setting up a munin server for each separate app; for that server I have to give it a list of nodes. It's probably clear from the Readme, but here's how nodes are specified: "nodes": [
{"fqdn": "myapp-name", "ipaddress": "10.0.0.1"},
{"fqdn": "anotherapp-name", "ipaddress": "10.0.0.2"},
] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README and commit messages are pretty explanatory, if you have any questions let me know.