Add cleaner dubious ownership error #3881
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves An error occurred! -- Detected dubious ownership in repository #3303, resolves "failed: fatal: detected dubious ownership in repository" when running lazygit on a newly initialized repository on a external drive #3757
Whilst the above issues expect lazygit to prompt the user to prompt whether it should modify their global Git configuration, I believe it is more pertinent that the user instead inform themselves of what's actually going on.
This PR adds a new known error message covering "dubious ownership". Rather than panicking when Git throws such an error, the below error message will be displayed:
Whilst I'm not against contributing to the implementation of the expected behaviour in the aforementioned issues, I think informing users of the risks involved is a necessary starting point.
go generate ./...
)